This has been solved as of 2019-01-25 with the 2.1.1 version of the Model service.

Thanks for responding to this Idea.

I believe there is room for optional Include Pages. An example could be alert messages, popus or modals, that are supposed to be diplayed on every page, but it's up to the editor if it should or should not be displayed. That could be controlled by publishing/unpublishing the Include Page.

This seems to have been the philosophy for DXA 1.7, where the following source code can be found for DefaultContentProvider:

protected virtual IEnumerable<IPage> GetIncludesFromModel(IPage page, Localization localization)

{

using (new Tracer(page.Id, localization))

{

List<IPage> result = new List<IPage>();

string[] pageTemplateTcmUriParts = page.PageTemplate.Id.Split('-');

IEnumerable<string> includePageUrls = localization.GetIncludePageUrls(pageTemplateTcmUriParts[1]);

foreach (string includePageUrl in includePageUrls)

{

IPage includePage = GetPage(SiteConfiguration.LocalizeUrl(includePageUrl, localization), localization);

if (includePage == null)

{

Log.Error("Include Page '{0}' not found.", includePageUrl);

continue;

}

result.Add(includePage);

}

return result;

}

}

It can be seen that the foreach loop properly continues whenever an Include Page is missing. This behaviour has changed in DXA 2.0, is it documented anywhere?

The logging should be done in the same way as all exceptions in the model service. For 1.7 it was logged in the application logs.

No error message should be displayed, just as it did not for 1.7.

Thanks for submitting this Idea. It makes sense, but we have some additional questions; see Status Notes above.