Gaetano Tasselli

I moved your comment in the appstore to here because this is right place to discuss issues with the plugins.

I ran some quick tests and would agree that we are seeing the same for each variant.  This seems odd because we just updated this plugin to support pt-BR and it was tested by some of our customers as well.  I am actually suspicious over whether DeepL have changed something on the server (won't be the first time), however we will take a look next week and take appropriate steps to resolve this.

You should also feel free to look at this yourself given you are confident enough to point to the API.  The sourcecode is opensource and it's here:

https://github.com/sdl/Sdl-Community/tree/master/DeepLMTProvider

Hi Gaetano,

the problem in the source code is that the variants PT-PT and PT-BR are still not transferred to the DeepL translation machine. You have to change the code in:

DeepLMTProvider\Sdl.Community.DeelLMTProvider\DeepLTranslationProviderConnecter.cs

Original code:

        public string Translate(LanguagePair languageDirection, string sourceText)
        {
            var targetLanguage = languageDirection.TargetCulture.TwoLetterISOLanguageName;
            var sourceLanguage = languageDirection.SourceCulture.TwoLetterISOLanguageName;
            var translatedText = string.Empty;
...

to be changed into:

        public string Translate(LanguagePair languageDirection, string sourceText)
        {
            var targetLanguage = languageDirection.TargetCulture.Name;
            if (targetLanguage != "pt-BR" & targetLanguage != "pt-PT")
            {
                targetLanguage = languageDirection.TargetCulture.TwoLetterISOLanguageName;
            }
            var sourceLanguage = languageDirection.SourceCulture.TwoLetterISOLanguageName;

            var translatedText = string.Empty;
...

Please note that the variants PT-PT and PT-BR are only allowed in the target language, see:

https://www.deepl.com/docs-api/translating-text/request/

Regards

Rainer

Hello Rainer Leukel,

I am currently working on a fix within the plugin, indeed the problem was at that step where the targetLanguage was set, so for the Portuguese language, instead of setting generally the "pt" code, it was needed to specify the flavor, like:"pt-PT" or "pt-BR".

With kind regards,

Florentina

Hello Gaetano Tasselli Rainer Leukel ,

The updated plugin is now available on the app store.

Thanks Florentina Caputa

Hello Gaetano Tasselli Rainer Leukel ,

The updated plugin is now available on the app store.

Thanks Florentina Caputa

Hello,

We tested the new DeepL plugin for Studio 2017 that is available on the appstore but the issue isn’t solved. As you can see in the attached zip :

• test_en-US.txt : the English source we used for the test
• test_pt-BR_DeepL-Online.txt and test_pt-PT_DeepL-Online.txt : the output is different for pt-PT and pt-BR when we use online DeepL
• test_pt-BR_DeepL-SDLPlugin.txt and test_pt-PT_DeepL-SDLPlugin.txt : the output is identical for pt-PT and pt-BR when we use the DeepL plugin for Studio 2017

Can you please check and maybe perform the same test before uploading a new plugin on the appstore ?

Thanks in advance !DeepL_PT-Variants.zip

Gaetano

Gaetano Tasselli

We have not done any work on the 2017 version.  Only on the 2019 and 2021 versions.  We are not supporting 2017 anymore with this plugin.  The source code is here if you wish to continue making changes to this yourself: https://github.com/sdl/Sdl-Community/tree/master/DeepLMTProvider